Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging set of fixes for upgrading smart contracts on Nightshade v2 #206

Merged
merged 10 commits into from
Sep 25, 2024

Conversation

referencedev
Copy link
Contributor

This contains mix of fixes:

  • Old fixes 2 year ago
  • New fixes for Nightshade v2

Merging it all into main so we have the up to date version that is going to be used by Ref Finance and probably other DAOs.

@think-in-universe
Copy link
Contributor

To fix the build failure, install the latest binaryen version will make the "Wasm copy and strip" step success.

Replace the binaryen version 105 with version 119 in .github/workflows/build.yml:

curl -L https://github.com/WebAssembly/binaryen/releases/download/version_105/binaryen-version_105-x86_64-linux.tar.gz | tar xzf -
echo "`pwd`/binaryen-version_105/bin" >> $GITHUB_PATH

=>

           curl -L https://github.com/WebAssembly/binaryen/releases/download/version_119/binaryen-version_119-x86_64-linux.tar.gz | tar xzf - 
           echo "`pwd`/binaryen-version_119/bin" >> $GITHUB_PATH 

@think-in-universe
Copy link
Contributor

think-in-universe commented Sep 19, 2024

The test failure is caused by the sputnikdao2-gasfix project which depends on near-sdk "3.1.0" and near-sdk-sim "3.1.0" that probably leads to the test build failure.

Is the sputnikdao2-gasfix project indeed needed? Could it be merged into the sputnikdao2 project?

marco-sundsk and others added 2 commits September 22, 2024 23:17
* ci: run test on macos-13

* ci: use llvm@14 on macos

* test: refactor tests with near-workspaces-js and ava

* test: refactor tests and fix failure

* ci: test on ubuntu-24.04 with node 20.17.0

* ci: test on ubuntu-22.04 with node 20.17.0
@ilblackdragon ilblackdragon merged commit 3d568f9 into near-daos:main Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants